Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][PostgreSQL] Lens migration for Query Duration Overview visualizations to Kibana version 8.4.0 #5749

Merged
merged 3 commits into from
Apr 6, 2023
Merged

[O11y][PostgreSQL] Lens migration for Query Duration Overview visualizations to Kibana version 8.4.0 #5749

merged 3 commits into from
Apr 6, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 30, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for PostgreSQL integration package

  • Statistics for PostgreSQL Lens migration:

PostgreSQL Dashboards  Before Migration   After Migration      
  Lens Visualization Lens Visualization New control panel
[Logs PostgreSQL] Query Duration Overview 0 1 1 0 0
  0 1 1 0 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 30, 2023 12:49
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T16:16:15.573+0000

  • Duration: 18 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.333% (28/30) 👍 60.0
Lines 97.041% (164/169) 👎 -2.959
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 30, 2023
Closed
7 tasks
@agithomas
Copy link
Contributor

@rajvi-elastic , there exist three panels in the dashboard. But, in the summary chart, only 1 is marked. Can you please look?

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic , there exist three panels in the dashboard. But, in the summary chart, only 1 is marked. Can you please look?

@agithomas, the other two panels are saved search. The search panels doesn't belong to either visualizations or lens category and also they are not migrated.

agithomas
agithomas approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete the peer review

@milan-elastic
Copy link
Contributor

Thanks @rajvi-elastic ! Approved!

@kush-elastic kush-elastic self-requested a review March 31, 2023 06:31
kush-elastic
kush-elastic approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic added enhancement New feature or request Integration:postgresql PostgreSQL v8.4.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 3, 2023
@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
aaf785f 
…s_migration-postgresql-query-duration-overview-8.4.0
@kush-elastic kush-elastic merged commit a006712 into elastic:main Apr 6, 2023
@elasticmachine
Copy link

Package postgresql - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=postgresql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:postgresql PostgreSQL Team:Service-Integrations Label for the Service Integrations team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @kush-elastic